[pickers] Stop using WrapperVariantContext in Clock
#8083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasTy
added
component: pickers
9 tasks
Netlify deploy previewNetlify deploy preview: https://deploy-preview-8083--material-ui-x.netlify.app/ Updated pagesNo updates. These are the results for the performance tests:
|
LukasTy
commented
Mar 1, 2023
packages/x-date-pickers/src/MobileDateTimePicker/MobileDateTimePicker.tsx
Show resolved
Hide resolved
LukasTy
commented
Mar 1, 2023
| @@ -41,7 +41,7 @@ DateTimePicker.propTypes = { | |||
| ampm: PropTypes.bool, | |||
| /** | |||
| * Display ampm controls under the clock (instead of in the toolbar). | |||
| * @default false | |||
| * @default true | |||
LukasTy
commented
Mar 1, 2023
| @@ -37,12 +37,14 @@ const DesktopDateTimePicker = React.forwardRef(function DesktopDateTimePicker<TD | |||
| seconds: null, | |||
| ...defaultizedProps.viewRenderers, | |||
| }; | |||
| const ampmInClock = defaultizedProps.ampmInClock ?? true; | |||
There was a problem hiding this comment.
This will be pointless until #7279 is implemented.
Do you think it makes sense to omit it for now?
alexfauquette
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7372
WrapperVariantContextinClockampmInClockprop defaultized totrueondesktopTimeandDateTimepicker types by removing duplicated (redundant)ampmprop and replacing it withampmInClockwith more specific (correct) default documentation