Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pickers] Remove WrapperVariantContext #8088

Merged
merged 3 commits into from
Mar 1, 2023
Merged

[pickers] Remove WrapperVariantContext #8088

merged 3 commits into from
Mar 1, 2023

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Mar 1, 2023 •
edited
Loading

Fixes #7372

Remove WrapperVariantContext from codebase

@LukasTy LukasTy added breaking change v6.x component: pickers This is the name of the generic UI component, not the React module! labels Mar 1, 2023
@LukasTy LukasTy self-assigned this Mar 1, 2023
@mui-bot
Copy link

mui-bot commented Mar 1, 2023 •
edited
Loading

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8088--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 701.2 1,397.2 701.2 982.64 252.607
Sort 100k rows ms 663.7 1,182.3 1,182.3 1,006.94 204.734
Select 100k rows ms 208 331.3 306.4 287.04 45.037
Deselect 100k rows ms 164 324.8 263.2 247.2 54.324

Generated by 🚫 dangerJS against 60dea09

@LukasTy LukasTy removed the v6.x label Mar 1, 2023
@LukasTy LukasTy merged commit 67ab509 into mui:next Mar 1, 2023
@LukasTy LukasTy deleted the remove-wrapper-variant-context branch March 1, 2023 15:32
@LukasTy LukasTy mentioned this pull request Mar 1, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexfauquette alexfauquette alexfauquette left review comments

@flaviendelangle flaviendelangle flaviendelangle approved these changes

Assignees

@LukasTy LukasTy

Labels
component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[pickers] Remove WrapperVariantContext usage
4 participants
@LukasTy @mui-bot @flaviendelangle @alexfauquette