Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Change default date from 4th of April to 17th of April for readability #8089

Merged
merged 2 commits into from
Mar 2, 2023
Merged

[docs] Change default date from 4th of April to 17th of April for readability #8089

merged 2 commits into from
Mar 2, 2023

Conversation

flaviendelangle
Copy link
Member

No description provided.

@flaviendelangle flaviendelangle added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels Mar 1, 2023
@flaviendelangle flaviendelangle self-assigned this Mar 1, 2023
@mui-bot
Copy link

mui-bot commented Mar 1, 2023 •
edited
Loading

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8089--material-ui-x.netlify.app/

Updated pages

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 620.6 1,015.4 637.9 803.34 167.464
Sort 100k rows ms 615.7 1,241.6 615.7 941.48 202.237
Select 100k rows ms 215.2 431.5 309.7 308.74 71.049
Deselect 100k rows ms 145.5 364.7 229.9 244.48 73.033

Generated by 🚫 dangerJS against 18cf767

@flaviendelangle flaviendelangle marked this pull request as ready for review March 1, 2023 15:18
LukasTy
LukasTy requested changes Mar 1, 2023
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great readability improvement! ❤️
As someone, who "can only read" ISO dates I appreciate it very much. 👏
Superb docs feedback point.

docs/data/date-pickers/base-concepts/ComponentFamilies.tsx Outdated Show resolved Hide resolved
docs/data/date-pickers/custom-components/ArrowSwitcherComponent.tsx Outdated Show resolved Hide resolved
docs/data/date-pickers/date-range-field/DateRangeFieldValue.js Outdated Show resolved Hide resolved
docs/data/date-pickers/date-time-range-field/DateTimeRangeFieldValue.tsx Outdated Show resolved Hide resolved
docs/data/date-pickers/fields/DateRangeFieldExamples.tsx Outdated Show resolved Hide resolved
@flaviendelangle flaviendelangle changed the title [docs] Change default date from 4th of April to 21st of April for readability [docs] Change default date from 4th of April to 17th of April for readability Mar 2, 2023
LukasTy
LukasTy approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@LukasTy LukasTy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👏
Very nice result and a few optional alignment improvements so that all the date and times are the same everywhere. 👍

packages/x-date-pickers/src/AdapterDayjs/AdapterDayjs.test.tsx Outdated Show resolved Hide resolved
packages/x-date-pickers/src/AdapterDayjs/AdapterDayjs.test.tsx Outdated Show resolved Hide resolved
packages/x-date-pickers/src/AdapterDayjs/AdapterDayjs.test.tsx Outdated Show resolved Hide resolved
@flaviendelangle flaviendelangle merged commit 08cf679 into mui:next Mar 2, 2023
@flaviendelangle flaviendelangle deleted the default-date-doc branch March 2, 2023 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasTy LukasTy LukasTy approved these changes

Assignees

@flaviendelangle flaviendelangle

Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@flaviendelangle @mui-bot @LukasTy