Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Allow multiple modules' augmentation #8098

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

MBilalShafi
Copy link
Member

Relates to #7968

As shown in this codesandbox, with current typing, if user tries to augment the same interface twice in a same project, typescript makes them both mandatory which is not always the expectation.

@MBilalShafi MBilalShafi added component: data grid This is the name of the generic UI component, not the React module! typescript v6.x labels Mar 2, 2023
@mui-bot
Copy link

mui-bot commented Mar 2, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8098--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 648.2 1,091 704.7 837.7 173.756
Sort 100k rows ms 647.3 1,257 647.3 967.94 196.335
Select 100k rows ms 222.3 427.4 308.6 316.32 65.286
Deselect 100k rows ms 159.8 324.2 250.2 242.84 53.437

Generated by 🚫 dangerJS against 2187e9f

@MBilalShafi MBilalShafi merged commit 82ddb82 into mui:next Mar 2, 2023
@MBilalShafi MBilalShafi deleted the allow-multiple-augmentation branch March 2, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! typescript v6.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants