Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[l10n] Add Catalan (Spain) (ca-ES) and improve Spanish (es-ES) locales #8498

Merged
merged 4 commits into from
Apr 4, 2023

Conversation

makenshikuro
Copy link
Contributor

Spanish (es-ES) locale improved

Adrian Bustos Paz added 2 commits April 4, 2023 09:40
Updated locale esEs for spanish language
@mui-bot
Copy link

mui-bot commented Apr 4, 2023

Netlify deploy preview

Netlify deploy preview: https://deploy-preview-8498--material-ui-x.netlify.app/

Updated pages

No updates.

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 595.5 1,086.3 667.3 825.76 176.399
Sort 100k rows ms 971.7 1,528.9 971.7 1,151.86 223
Select 100k rows ms 205.9 418.1 306.7 305.86 69.43
Deselect 100k rows ms 147.3 299.1 222.7 233.24 54.384

Generated by 🚫 dangerJS against a558576

@zannager zannager added the l10n localization label Apr 4, 2023
@makenshikuro
Copy link
Contributor Author

Hi, I don't understand the reason for test_static fail.

@alexfauquette
Copy link
Member

alexfauquette commented Apr 4, 2023

@makenshikuro Thanks for the contribution

You have to run yarn l10n. It will update the json files used in the docs to list locales and their completion state.

You should also export your new caES.js file in the index.js of the same folder. After exporting it, you should run yarn docs:api (this script list all the elements exported by the package)

I'm updating the PR title, but it's just to help us when writing the release changelog

@alexfauquette alexfauquette changed the title [l10n] Add Catalan (Spain) (ca-ES) locale [l10n] Add Catalan (Spain) (ca-ES) and improve Spanish (es-ES) locales Apr 4, 2023
@LukasTy LukasTy added the component: pickers This is the name of the generic UI component, not the React module! label Apr 4, 2023
export const caES.ts
@alexfauquette
Copy link
Member

Are you on windows? The path generated by script look weird

We will take care of letting the CI pass

@makenshikuro
Copy link
Contributor Author

Yes, I'm on Windows.
Tell me if you need something from my side.

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, every thing seems good

Thanks again for the translation and for the fixes :)

@alexfauquette alexfauquette merged commit 7873522 into mui:master Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants