-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nextjs] Fix tsconfig's path resolving #182
Conversation
Can I support the progress of this PR in any way? |
Would be amazing to see progress with this PR. Issue #171 is a blocker for us starting to use Pigment CSS. Is there anything we can do to help get this PR reviewed? |
Would you be open to testing out the PR build package in your app and see if it's solving the issue for you ? If yes, can you replace the Pigment CSS versions with these in your package.json ? {
"dependencies": {
"@pigment-css/react": "https://pkg.csb.dev/mui/pigment-css/commit/76e39c75/@pigment-css/react",
},
"devDependencies": {
"@pigment-css/nextjs-plugin": "https://pkg.csb.dev/mui/pigment-css/commit/76e39c75/@pigment-css/nextjs-plugin"
}
} |
Hi @brijeshb42, I've just swapped to the PR versions just now and unfortunately that didn't fix it for us. I was about to create a repro but @effektsvk has already provided a perfect repro of our problem at https://github.com/effektsvk/pigment-css-repro-next-js. |
Thanks. I'll take a look. |
I've replaced "devDependencies": {
"@pigment-css/nextjs-plugin": "^0.0.24"
} with "devDependencies": {
"@pigment-css/nextjs-plugin": "https://pkg.csb.dev/mui/pigment-css/commit/76e39c75/@pigment-css/nextjs-plugin"
} and it fixed EISDIR errors for me. Is it possible to merge this in order to resolve #211 and keep working on #171 in a separate PR? |
The solution from @abriginets also worked for resolving the constant EISDIR errors I've been experiencing. I'd also strongly suggest a swift approval for the suggested pull request. |
Really hope that this PR can be merge and that there will be an updated package available soon. We're running into the EISDIR as well and are a stucked with our Pigment css migration until this is resolved 🙏 |
when trying to internpolate a styled component in another Fixes mui#171
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Do you know when this fix will be released? 🙏 |
Already in the process - #308 |
Released |
Tried version 0.0.26 and I'm not getting the EISDIR however it fails to resolve my TS aliases in my styled components: Basic example: Openingstatus.tsx
Chip.tsx:
tsconfig.json:
=> Error:
NOTE: I've used resolution/overrides to force all dependencies up to the 0.0.26 version of |
Could you share a POC with the error here ? It'll be easier to debug |
You could use this repo pigment-css-repro-next-js And just update these parts in package.json: "@mui/material": "6.1.6", "resolutions": { |
@brijeshb42 Forked the other reproduction repo with updated (0.0.26) version here: |
when trying to interpolate a styled component in another
Fixes #171