[TypeScript] Fix sx types and missing style prop from layout components
#191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brijeshb42
reviewed
Aug 5, 2024
| @@ -12,6 +12,8 @@ type StackBaseProps = { | |||
| className?: string; | |||
| }; | |||
|
|
|||
| declare const Stack: PolymorphicComponent<StackBaseProps>; | |||
There was a problem hiding this comment.
Can you add a typecheck test for the change if possible ?
siriwatknp
changed the title
style prop from layout componentssx types and missing style prop from layout components
brijeshb42
approved these changes
Aug 6, 2024
This was referenced Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found this issue from mui/material-ui#43065 (review)
It's not possible to do this at the moment:
The
styleattribute is not supported inPigmentGrid