[plugin] Fix bug related to path separator on Windows #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While debugging on Windows, I found that (atleast on Windows 11), the path separator was `/` instead of the expected `\` resulting in some files being skipped from being transformed from the `node_modules`. So the fix first normalizes the path first as per the platform and then checks for the `transformLibraries`'s presence in the normalized path.
mnajdova
reviewed
Aug 30, 2024
| @@ -132,17 +132,19 @@ export default function wywVitePlugin({ | |||
| .filter((m): m is ModuleNode => !!m); | |||
| }, | |||
| async transform(code, url) { | |||
| const [id] = url.split('?', 1); | |||
|
|
|||
| const [filePath] = url.split('?', 1); | |||
There was a problem hiding this comment.
How does this arg differs from the one in the unplugin (url vs filePath)?
There was a problem hiding this comment.
No difference. Updated to use same names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging on Windows, I found that (atleast on Windows 11), the path separator was
/instead of the expected\resulting in some files being skipped from being transformed from thenode_modules.So the fix first normalizes the path as per the platform and then checks for the
transformLibraries's presence in the normalized path.Fixes - mui/material-ui#43487