[docs] More docs infra changes #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
brijeshb42
commented
Nov 6, 2024
•
brijeshb42
commented
- Separate text content and it's wrapper's styles
- Use env variables for constants
- Use docs infra config from @mui/monorepo
- Correctly link md or mdx files to Github
- Hide version selector if it has only one version
- Simplify and enable bottom pagination style
- Setup code highlighting of mdx code content with built-in shiki theme
- I have followed (at least) the PR section of the contributing guide.
brijeshb42
force-pushed
the
docs-update
branch
from
b7ef6f7 to
62d641f
Compare
brijeshb42
force-pushed
the
docs-update
branch
6 times, most recently
from
a2d7476 to
f57f341
Compare
* Separate text content and it's wrapper's styles * More use of env variables for constants * Use docs infra config from @mui/monorepo * Correctly link md or mdx files to Github * Hide version selector if it has only one version * Simplify and enable bottom pagination style * Setup code highlighting of mdx code content with built-in shiki theme
brijeshb42
force-pushed
the
docs-update
branch
from
f57f341 to
abc48b8
Compare
mnajdova
reviewed
Nov 11, 2024
|
|
||
| const nextConfig: NextConfig = { | ||
| trailingSlash: false, | ||
| env: { | ||
| DATA_DIR, | ||
| CURRENT_VERSION: rootPackage.version, |
There was a problem hiding this comment.
To be used in version dropdown (or span).
mnajdova
reviewed
Nov 11, 2024
| @@ -45,7 +45,9 @@ export function AppBar() { | |||
| <IconLinkButton useNextLink href="/" label="Pigment CSS" size={3}> | |||
| <PigmentIcon /> | |||
| </IconLinkButton> | |||
| <DocsVersionSelector currentVersion={currentVersion} versions={supportedVersions} /> | |||
| {supportedVersions.length > 1 && ( | |||
There was a problem hiding this comment.
Instead of hiding we can have a span to show the current version.
There was a problem hiding this comment.
Will update in a followup.
mnajdova
approved these changes
Nov 11, 2024
Makes sense. I was testing locally with stubs. Going forward, most of the PRs for docs will be about the actual content. So we'll get a better idea then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.