[nextjs] Fix path resolution #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brijeshb42
force-pushed
the
fix/171
branch
4 times, most recently
from
a6085c8 to
cd15629
Compare
siriwatknp
reviewed
Nov 11, 2024
This reverts the previous "fix" and uses the newly available loaderContext from unplugin to do path resolution. Previous solution was "hacky" in a sense since at that time, Unplugin did not expose loader's context. So we had to do things manually which did not work reliably. Now that we have "loaderContext" data, it's straighforward to just call `loaderContext.resolve()` with the path and this works as expected. Tested on our docs and user submitted repro repository.
|
@brijeshb42 How does the release process look like (when will there be a 0.0.27 patch release)? |
|
Published new version |
|
Thanks @brijeshb42 can confirm all my aliases working again with version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts the previous "fix" and uses the newly available
loaderContextfrom unplugin to do path resolution. Previous solution was "hacky" in a sense since at that time, Unplugin did not expose loader's context. So we had to do things manually which did not work reliably. Now that we have "loaderContext" data, it's straighforward to just callloaderContext.resolve()with the path and this works as expected.Tested on our docs and user submitted repro repository.
Fixes #171