Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement @pigment-css/theme package #341

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

brijeshb42
Copy link
Contributor

At this point, it is just a helper library for extending TS types of the user theme.

This package is a bunch of TS helpers to easily allow users to override the Theme type which will be used in @pigment-css/core and @pigment-css/react packages.

This is the 1st package in v1 series. Next PRs on top will actually use this package.

@brijeshb42 brijeshb42 added the package: theme Specific to @pigment-css/theme label Dec 4, 2024
@brijeshb42 brijeshb42 added this to the Road to v1 milestone Dec 4, 2024
@brijeshb42 brijeshb42 requested a review from mnajdova December 4, 2024 15:22
@brijeshb42 brijeshb42 force-pushed the v1/pkg-theme branch 6 times, most recently from 1afbdbb to 791e88b Compare December 4, 2024 15:54
At this point, it is just a helper library for extending TS types of the user theme.
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll need to be careful with these complex types and make sure we don't get trapped into the TS check performance issues we had in Material UI. I am happy to try and see how it goes :)

Let's merge it.

t('$palette.main');

// @ts-expect-error
t('$palette.secondary');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@brijeshb42 brijeshb42 merged commit 0590bc0 into mui:master Dec 5, 2024
12 checks passed
@brijeshb42 brijeshb42 deleted the v1/pkg-theme branch December 5, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: theme Specific to @pigment-css/theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants