Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence sentry warning #1102

Merged
merged 3 commits into from
Oct 10, 2022
Merged

Silence sentry warning #1102

merged 3 commits into from
Oct 10, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Oct 6, 2022

Silence warnings that Sentry shows for getsentry/sentry-javascript#3852

@render
Copy link

render bot commented Oct 6, 2022

Your Render PR Server URL is https://toolpad-pr-1102.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-ccv96eha6gdqlscl4n90.

@oliviertassinari oliviertassinari requested a deployment to sentry-release - toolpad-db PR #1102 October 6, 2022 08:35 — with Render Abandoned
@Janpot Janpot requested a review from apedroferreira October 6, 2022 09:15
apedroferreira
apedroferreira approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, i was setting this locally but this is better

@Janpot Janpot merged commit f0148d3 into master Oct 10, 2022
@Janpot Janpot deleted the sentry-release branch October 10, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
Toolpad
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Janpot @apedroferreira @oliviertassinari @zannager