Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure parameters work in query preview #1138

Merged
merged 3 commits into from
Oct 12, 2022
Merged

Make sure parameters work in query preview #1138

merged 3 commits into from
Oct 12, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Oct 12, 2022

Fixes #1096 (comment)

This regressed. I'm updating the types to prevent this in the future

@render
Copy link

render bot commented Oct 12, 2022

@oliviertassinari oliviertassinari requested a deployment to bad-merge-fix - toolpad-db PR #1138 October 12, 2022 08:08 — with Render Abandoned
@Janpot Janpot marked this pull request as ready for review October 12, 2022 08:10
@Janpot Janpot requested a review from bytasv October 12, 2022 08:11
@Janpot Janpot added priority: important This change can make a difference regression A bug, but worse labels Oct 12, 2022
@Janpot Janpot merged commit 95d3d2c into master Oct 12, 2022
@Janpot Janpot deleted the bad-merge-fix branch October 12, 2022 10:15
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work priority: important This change can make a difference regression A bug, but worse
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants