Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[app] Fix manifest 401 loading #1146

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Oct 12, 2022

You can take the preview of #1141 (comment) and you will get this in the console:

Screenshot 2022-10-13 at 01 01 15

I was writing a new custom date picker component, I'm usually using console.log to make sure that each step along the way is correct, but I had this warning, it harms my DX 😁. Now, it loads correctly

Screenshot 2022-10-13 at 02 23 09

https://toolpad-pr-1146.onrender.com/

@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Oct 12, 2022
@render
Copy link

render bot commented Oct 12, 2022

@oliviertassinari oliviertassinari requested a deployment to fix-manifest-loading - toolpad-db PR #1146 October 12, 2022 23:12 — with Render Abandoned
@oliviertassinari oliviertassinari merged commit b61449a into master Oct 13, 2022
@oliviertassinari oliviertassinari deleted the fix-manifest-loading branch October 13, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants