[runtime] hide queries in the browser #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://toolpad-pr-1155.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cd43d3ta499ckjpeeeug. |
oliviertassinari
requested a deployment
to
WANG-hide-query - toolpad-db PR #1155
Render
Abandoned
2 tasks
| await editorModel.componentEditor.waitFor(); | ||
| await editorModel.componentEditor.waitFor({ state: 'visible' }); | ||
|
|
||
| const labelControlInput = editorModel.componentEditor.getByLabel('label', { exact: true }); |
There was a problem hiding this comment.
i guess i hadn't found this selector that gets the input for a label? seems pretty useful
| await labelControlInputLocator.fill(TEST_VALUE_2); | ||
|
|
||
| await expect(firstInputLabelLocator).toHaveText(TEST_VALUE_2); | ||
| await inputByLabel.waitFor({ state: 'visible' }); |
There was a problem hiding this comment.
So we're not checking if the value in the label matches in the end anymore? Was there any issue with that?
There was a problem hiding this comment.
Yes we are, if the value doesn't match this selector wouldn't locate elements
There was a problem hiding this comment.
oh it checks with that value already, i missed that. looks good then!
apedroferreira
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1052
@apedroferreira had a bit of trouble with the propControls test. I refactored the locators to be a bit more stable