Undo/redo through different views #1417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apedroferreira
added
core
apedroferreira
force-pushed
the
undo-redo-with-views
branch
from
6837de4 to
a1fe951
Compare
…urrent view info (initial setup)
Janpot
reviewed
Dec 12, 2022
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
requested a deployment
to
undo-redo-with-views - toolpad-db PR #1417
Render
Abandoned
github-actions
bot
removed
the
PR: out-of-date
apedroferreira
commented
Dec 20, 2022
| @@ -965,83 +955,138 @@ export default function RenderOverlay({ canvasHostRef }: RenderOverlayProps) { | |||
| const isDraggingOverLayoutSlot = dragOverSlot?.type === 'layout'; | |||
| const isDraggingOverElement = appDom.isElement(dragOverNode); | |||
|
|
|||
| domApi.update((draft) => { | |||
| let parent = appDom.getParent(draft, dragOverNode); | |||
| domApi.update( | |||
There was a problem hiding this comment.
This is all just formatting changes except the second argument passed to domApi.update (which caused the reformatting). Maybe I should extract this nested function...
oliviertassinari
temporarily deployed
to
undo-redo-with-views - toolpad PR #1417
Render
Destroyed
github-actions
bot
added
the
PR: out-of-date
oliviertassinari
requested a deployment
to
undo-redo-with-views - toolpad-db PR #1417
Render
Abandoned
github-actions
bot
removed
the
PR: out-of-date
oliviertassinari
temporarily deployed
to
undo-redo-with-views - toolpad PR #1417
Render
Destroyed
|
This should be good to merge, will merge soon if there's no more feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to the correct view on undo/redo.
Also closes #1460.
Video (undo starts at 1:36):
Screen.Recording.2022-12-20.at.13.56.17.mov
Preview URL: https://toolpad-pr-1417.onrender.com/
Summary of changes:
domApito set current view and tab. View can also be changed withdomApi.updateif we want 1 action to represent a DOM change + view change, for example, which was needed in some situations.There's many different approaches we could use for this logic and to extend/improve it. I think this a good starting point for further changes, even if it's not the final solution.
(Also we might still be able to use DOM diffs to get the current view automatically, just starting out with something simpler)
Continuing to follow the checklist in #226
Relevant discussion reference: #1225 (comment)