Fix function editor save #1507
Merged
Fix function editor save #1507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested a deployment
to
fix-save - toolpad-db PR #1507
Render
Abandoned
| @@ -106,6 +106,9 @@ export default function QueryNodeEditorDialog<Q>({ | |||
| const node = useLatest(nodeProp); | |||
|
|
|||
| const [input, setInput] = React.useState<appDom.QueryNode<Q>>(node); | |||
| React.useEffect(() => { | |||
There was a problem hiding this comment.
This is repeated, there's the same effect in line 237 (I might've added in the last PR I merged).
There was a problem hiding this comment.
Ok, I'm removing the other one to keep it closer to where the state is created. It's a good convention to keep these lines together when the behavior is desired of reinitializing when initial value changes.
|
|
||
| await expect(editorModel.appCanvas.getByText('edited hello')).toBeVisible(); | ||
|
|
||
| await editorModel.componentEditor.getByRole('button', { name: 'edited' }).click(); |
There was a problem hiding this comment.
When we add more tests for the query editor it might make sense for some of these to have methods/properties we can reuse.
apedroferreira
requested changes
Jan 4, 2023
oliviertassinari
temporarily deployed
to
fix-save - toolpad PR #1507
Render
Destroyed
apedroferreira
approved these changes
Jan 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1452
Turns out the shortcut was working after all. The problem was that the update didn't reflect in the UI afterwards