Reorganize shared utils #1539
Merged
Reorganize shared utils #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested a deployment
to
reorg-shared-utils - toolpad-db PR #1539
Render
Abandoned
Janpot
commented
Jan 10, 2023
| if (!mod.error) { | ||
| const cacheId = `// ${id}\n${mod.code}`; | ||
| const fromCache = cache.get(cacheId); | ||
| const loadedModules = React.useMemo(() => { |
There was a problem hiding this comment.
Just wrapping in a useMemo to satisfy https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-no-constructed-context-values.md
Hide whitespace to see the real changes
apedroferreira
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
I'm also reordering a bit the utility imports from @mui/toolpad-core in anticipation of creating a utils package that we can reuse. @mui/toolpad-core is intended to share logic between the components and the runtime, we should aim at keeping it lean, utilities meant for broader use can go in new package. For this package we will encourage subpath imports to maximize treeshakeability e.g.
Sounds great to keep the bundle size low!
github-actions
bot
added
the
PR: out-of-date
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
oliviertassinari
temporarily deployed
to
reorg-shared-utils - toolpad PR #1539
Render
Destroyed
github-actions
bot
removed
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a
useNonNullableContextfunction to replacecreateProvidedContextdown the line. The problem withcreateProvidedContextis that it makes it impossible for the react eslint rules to detect stable/unstable context values. In this PR I'm replacing some instances ofcreateProvidedContextwith this new hook and fixing the associate eslint issuesI'm also reordering a bit the utility imports from
@mui/toolpad-corein anticipation of creating a utils package that we can reuse.@mui/toolpad-coreis intended to share logic between the components and the runtime, we should aim at keeping it lean, utilities meant for broader use can go in new package. For this package we will encourage subpath imports to maximize treeshakeability e.g.I'm not making that switch in this PR, but as a first step, I'm just disallowing importing utilities from
@mui/toolpad-core.