Remove obsolete dom reducer actions #1541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
requested a deployment
to
remove-unnecessary-actions - toolpad-db PR #1541
Render
Abandoned
oliviertassinari
temporarily deployed
to
remove-unnecessary-actions - toolpad PR #1541
Render
Destroyed
apedroferreira
approved these changes
Jan 10, 2023
There was a problem hiding this comment.
Looks good, definitely more readable and shorter!
We can also remove some methods such as domApi.setNodeNamespace and domApi.setNodeName and make them usable only with domApi.update if you think it's worth doing. I kept them separate because I think they're still kind of useful like that.
oliviertassinari
temporarily deployed
to
remove-unnecessary-actions - toolpad PR #1541
Render
Destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking a look at the undo/redo logic. Trying to move more of the logic inside of the reducer. Saw an opportunity to simplify some of the logic (always prefer positive logic) and remove some of the actions. Having a single
DOM_UPDATEaction should hopefully make it easier to detect the nature of an update (updating the same property, or a new one)