Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid resubscribing in useSyncExternalStore on every render #1554

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Avoid resubscribing in useSyncExternalStore on every render #1554

merged 2 commits into from
Jan 17, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jan 13, 2023

Realized we're currently a bit wasteful while reading through https://beta.reactjs.org/reference/react/useSyncExternalStore

@oliviertassinari oliviertassinari requested a deployment to stabilize-useSyncExternalStore - toolpad-db PR #1554 January 13, 2023 14:27 — with Render Abandoned
@oliviertassinari oliviertassinari temporarily deployed to stabilize-useSyncExternalStore - toolpad PR #1554 January 13, 2023 14:29 — with Render Destroyed
@oliviertassinari oliviertassinari temporarily deployed to stabilize-useSyncExternalStore - toolpad PR #1554 January 13, 2023 14:30 — with Render Destroyed
@Janpot Janpot added the core Infrastructure work going on behind the scenes label Jan 13, 2023
@Janpot Janpot enabled auto-merge (squash) January 13, 2023 14:45
@Janpot Janpot merged commit 2edd7b3 into master Jan 17, 2023
@Janpot Janpot deleted the stabilize-useSyncExternalStore branch January 17, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apedroferreira apedroferreira apedroferreira approved these changes

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Janpot @apedroferreira @oliviertassinari