Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate .gitignore on dev command #1705

Merged
merged 135 commits into from
Mar 24, 2023
Merged

Generate .gitignore on dev command #1705

merged 135 commits into from
Mar 24, 2023

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented Feb 22, 2023 •
edited
Loading

Closes #1666

Generate .gitignore file in .toolpad-generated folder on running toolpad dev.

Base automatically changed from direction-13 to master March 20, 2023 08:03
@Janpot Janpot changed the base branch from master to direction-13 March 20, 2023 08:32
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 20, 2023
@Janpot Janpot changed the base branch from direction-13 to master March 20, 2023 08:45
@apedroferreira
Copy link
Member Author

Note: let's generate the gitignore file every time with the dev command and place it in the generated folder.

@apedroferreira apedroferreira requested review from Janpot and a team March 21, 2023 19:26
@apedroferreira apedroferreira changed the title Generate files (.gitignore, .env...) on dev command Generate .gitignore on dev command Mar 21, 2023
bharatkashyap
bharatkashyap approved these changes Mar 23, 2023
View reviewed changes
Copy link
Member

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@apedroferreira apedroferreira merged commit 8172526 into master Mar 24, 2023
@apedroferreira apedroferreira deleted the generate-files-dev-command branch March 24, 2023 12:19
@apedroferreira
Copy link
Member Author

I guess I might not have ran the tests in the latest master? I'll give it a look if this PR is making CI fail.

@Janpot
Copy link
Member

Janpot commented Mar 24, 2023 •
edited
Loading

It seems like we created two parallel systems of initializing project files. #1796
I'm including the changes of this PR in mine. It colocates the logic with the regular local project interfacing code so it can share more primitives. It also has a finer grained control for each file we want to initialize.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatkashyap bharatkashyap bharatkashyap approved these changes

@Janpot Janpot Awaiting requested review from Janpot

Assignees

@apedroferreira apedroferreira

Labels
core Infrastructure work going on behind the scenes new feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a .gitignore file to the .toolpad-generated folder
4 participants
@apedroferreira @Janpot @bharatkashyap @oliviertassinari