Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use next.js custom server #1723

Merged
merged 136 commits into from
Mar 27, 2023
Merged

Use next.js custom server #1723

merged 136 commits into from
Mar 27, 2023

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Mar 2, 2023

Remove the next command for starting toolpad and instead use a custom server.

  • this gives us more control over the process in which next.js runs, we can add a pipeline to build user applications and components.
  • this gives us control over the http server next.js runs inside. This will allow us to run request handlers that are not controlled by next.js. We can serve the user application separately from the editor. e.g. we can run a separate webpack-dev-middleware for the user application.

Base automatically changed from direction-13 to master March 20, 2023 08:03
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 20, 2023
@Janpot Janpot changed the base branch from master to direction-13 March 20, 2023 08:36
@Janpot Janpot changed the base branch from direction-13 to master March 20, 2023 08:37
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 20, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 24, 2023
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 24, 2023
@Janpot Janpot enabled auto-merge (squash) March 27, 2023 08:25
@Janpot Janpot merged commit ffb546e into master Mar 27, 2023
@Janpot Janpot deleted the custom branch March 27, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants