Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Chart component to X charts library #2500

Merged
merged 51 commits into from
Nov 2, 2023

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented Aug 16, 2023

Use @mui/x-charts for the Chart component.
Includes some general improvements/fixes for charts too.

Closes #2309
Also closes #2542
Also closes #2592
Also closes #2602

Screenshot 2023-10-31 at 19 58 05

@apedroferreira apedroferreira added the feature: Components Button, input, table, etc. label Aug 16, 2023
@apedroferreira apedroferreira self-assigned this Aug 16, 2023
@apedroferreira

This comment was marked as resolved.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 16, 2023
@Janpot

This comment was marked as resolved.

@alexfauquette

This comment was marked as resolved.

@alexfauquette

This comment was marked as resolved.

@alexfauquette alexfauquette reopened this Aug 22, 2023
@apedroferreira

This comment was marked as resolved.

@apedroferreira
Copy link
Member Author

Created an issue with feedback/issues I ran into in mui/mui-x#10140.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 25, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 25, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 19, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 22, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 27, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 27, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 18, 2023
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 18, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 31, 2023
@apedroferreira apedroferreira marked this pull request as ready for review October 31, 2023 19:53
@apedroferreira apedroferreira requested a review from a team October 31, 2023 20:27
Copy link
Member

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Are there any documentation updates which would need to be made?

@apedroferreira
Copy link
Member Author

Looks good! Are there any documentation updates which would need to be made?

We don't have very deep documentation for the Chart, just the automatic one...
I guess I could add something, probably in a separate PR.

Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@apedroferreira
Copy link
Member Author

Merging, I'll keep it noted to add documentation for the Chart component.

@apedroferreira apedroferreira merged commit dd8d147 into mui:master Nov 2, 2023
3 checks passed
@apedroferreira apedroferreira deleted the migrate-x-charts branch November 2, 2023 13:47
@oliviertassinari oliviertassinari added the enhancement This is not a bug, nor a new feature label Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature feature: Components Button, input, table, etc.
Projects
None yet
5 participants