Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support serverside sorting/filtering #2982

Merged
merged 17 commits into from
Dec 13, 2023
Merged

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Dec 7, 2023

@Janpot Janpot added the new feature New feature or request label Dec 7, 2023
@Janpot Janpot changed the title [WIP] serverside filtering [WIP] serverside sorting/filtering Dec 8, 2023
@Janpot Janpot changed the title [WIP] serverside sorting/filtering Support serverside sorting/filtering Dec 8, 2023
@Janpot Janpot marked this pull request as ready for review December 8, 2023 18:06
@Janpot Janpot requested a review from a team December 8, 2023 18:09
Copy link
Member

@apedroferreira apedroferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really, really good! The docs look pretty clear, I went through them and understood well how to use these features.
Maybe an image example of the source filters/sorting in the datagrid UI would make it even clearer in the docs.

Also I'm seeing an error on empty data grids when I place them:
Screenshot 2023-12-12 at 18 03 45

docs/data/toolpad/concepts/data-providers.md Outdated Show resolved Hide resolved
docs/data/toolpad/concepts/data-providers.md Outdated Show resolved Hide resolved
skip: start,
take: pageSize,

where:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a bit cumbersome to adapt to Prisma, but not really sure how that could be improved, it's hard to map from our filters to theirs...
I think it's expected, it was just my first thought.

Copy link
Member Author

@Janpot Janpot Dec 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Next step is creating an adapter for Prisma, but one thing at a time

Janpot and others added 4 commits December 12, 2023 19:10
Co-authored-by: Pedro Ferreira <10789765+apedroferreira@users.noreply.github.com>
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
Co-authored-by: Pedro Ferreira <10789765+apedroferreira@users.noreply.github.com>
Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
@Janpot
Copy link
Member Author

Janpot commented Dec 13, 2023

Fixed the error and added extra videos in the docs that illustrate filtering and sorting

@Janpot Janpot enabled auto-merge (squash) December 13, 2023 11:32
@Janpot Janpot merged commit 1d39974 into mui:master Dec 13, 2023
11 checks passed
@Janpot Janpot deleted the server-side-filtering branch December 13, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support server-side filtering in data grid. Datagrid in Toolpad should support server-side sorting
2 participants