-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support serverside sorting/filtering #2982
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really, really good! The docs look pretty clear, I went through them and understood well how to use these features.
Maybe an image example of the source filters/sorting in the datagrid UI would make it even clearer in the docs.
Also I'm seeing an error on empty data grids when I place them:
skip: start, | ||
take: pageSize, | ||
|
||
where: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a bit cumbersome to adapt to Prisma, but not really sure how that could be improved, it's hard to map from our filters to theirs...
I think it's expected, it was just my first thought.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Next step is creating an adapter for Prisma, but one thing at a time
Co-authored-by: Pedro Ferreira <10789765+apedroferreira@users.noreply.github.com> Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
Co-authored-by: Pedro Ferreira <10789765+apedroferreira@users.noreply.github.com> Signed-off-by: Jan Potoms <2109932+Janpot@users.noreply.github.com>
Fixed the error and added extra videos in the docs that illustrate filtering and sorting |
Adds
sortModel
andfilterModel
to the datasourcegetRecords
methodCloses #2886
Closes #2539
Docs: