Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Adds reusable workflow for closing messages #4076

Conversation

michelengelen
Copy link
Member

related issue: mui/mui-public#156

@michelengelen michelengelen added enhancement This is not a bug, nor a new feature scope: infra Org infrastructure work going on behind the scenes labels Sep 11, 2024
@michelengelen michelengelen self-assigned this Sep 11, 2024
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not looking forward to getting an extra unnecessary notification in my inbox for every closed issue 🙂

@michelengelen
Copy link
Member Author

Not looking forward to getting an extra unnecessary notification in my inbox for every closed issue 🙂

you won't get that! It specifically looks for maintainer rights and if thats the case you aren't being tagged on the message! :D

@michelengelen michelengelen merged commit f2a93a0 into mui:master Sep 11, 2024
15 checks passed
@michelengelen michelengelen deleted the automation/add-closing-message-workflow branch September 11, 2024 14:21
@Janpot
Copy link
Member

Janpot commented Sep 16, 2024

@michelengelen What I meant was for example: I closed this issue. Which doesn't generate a notification. But then I still get pinged 1 minute later for the closing message. I'm subscribed to the issue, so I get notifications, even if I'm not tagged.

@michelengelen
Copy link
Member Author

@michelengelen What I meant was for example: I closed this issue. Which doesn't generate a notification. But then I still get pinged 1 minute later for the closing message. I'm subscribed to the issue, so I get notifications, even if I'm not tagged.

Well, yeah ... that one is unfortunately necessary for this... its more a fault of how github handles notifications and so on though ... there is very little customizability for notifications in place

@oliviertassinari
Copy link
Member

@Janpot Right, so it does this:

SCR-20240916-qlny

I think a Gmail filter does the trick. Guide updated: https://www.notion.so/mui-org/GitHub-guide-a2d05d63152244cfa568927deb34b25b?pvs=4#103cbfe7b66080758757c4e30bb6f9f1. I have implemented it on my end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This is not a bug, nor a new feature scope: infra Org infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants