Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] [docs] Improve tutorial example, docs, CLI installation #4225

Merged
merged 5 commits into from
Oct 9, 2024

Conversation

bharatkashyap
Copy link
Member

@bharatkashyap bharatkashyap added docs Improvements or additions to the documentation create-toolpad-app Issues related to the `create-toolpad-app` CLI tool labels Oct 7, 2024
@bharatkashyap bharatkashyap changed the title fix: tutorial example, docs, CLI installation [cli] [docs] Improve tutorial example, docs, CLI installation Oct 7, 2024
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

import { AppProvider } from '@toolpad/core/AppProvider';
import { DashboardLayout } from '@toolpad/core/DashboardLayout';
import { PageContainer } from '@toolpad/core/PageContainer';
import { useDemoRouter } from '@toolpad/core/internals';

const NAVIGATION = [
{
segment: 'page',
title: 'Page',
segment: '',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'' is the default segment so not sure if we should remove it in all examples or if its better to be more explicit anyway.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be okay to be explicit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 7, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Oct 8, 2024
@bharatkashyap bharatkashyap merged commit 4169302 into mui:master Oct 9, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-toolpad-app Issues related to the `create-toolpad-app` CLI tool docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[core] Bootstrapping doesn't work
3 participants