Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove editor segment from route #800

Merged
merged 7 commits into from
Sep 9, 2022
Merged

Remove editor segment from route #800

merged 7 commits into from
Sep 9, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Aug 16, 2022

remove the /editor/ segment from the toolpad editor url so that the path structure aligns with the end-user application routing

/_toolpad/app/cl6qmo6ih0474qaldgzboda8d/editor/pages/cl6qmo6is000aqaldcr4m8z0k
becomes
/_toolpad/app/cl6qmo6ih0474qaldgzboda8d/pages/cl6qmo6is000aqaldcr4m8z0k

so that one can substitute the /deploy/ prefix with /_toolpad/app/ to get to the editor.

@render
Copy link

render bot commented Aug 16, 2022

@oliviertassinari oliviertassinari requested a deployment to editor-routing - toolpad-db PR #800 August 16, 2022 08:39 — with Render Abandoned
@Janpot Janpot marked this pull request as ready for review August 16, 2022 12:31
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 17, 2022
@github-actions github-actions bot added PR: out-of-date The pull request has merge conflicts and can't be merged and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Aug 17, 2022
@render
Copy link

render bot commented Sep 9, 2022

@oliviertassinari oliviertassinari requested a deployment to editor-routing - toolpad-db PR #800 September 9, 2022 10:27 — with Render Abandoned
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 9, 2022
@Janpot Janpot merged commit 4441687 into master Sep 9, 2022
@Janpot Janpot deleted the editor-routing branch September 9, 2022 10:55
@zannager zannager added Toolpad scope: toolpad-studio Abbreviated to "studio" labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: toolpad-studio Abbreviated to "studio" Toolpad
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants