Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor integration tests #831
Editor integration tests #831
Changes from 6 commits
a13efd4
c924d93
618227a
f8e290d
17f5f69
e54c0be
6ea3149
fc7ced3
bc6d1d5
824e7dc
a1f5d2b
d3127ae
029255f
c46e557
5022ab0
b8e9d12
cdf0e9e
7493a47
83846bd
1e763da
3d90c12
135e1b5
49b379d
35ca944
d47a040
c055560
86eb6ee
bce8fe0
5271a22
23ba962
fc21241
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could improve dialog selectors a bit: https://github.com/mui/mui-toolpad/pull/838/files#diff-e537b99227068da9665d973e6573a1cd6da8d36be778d2aba43b159890a43d99R30
But we can merge this as is and use the ToolpadHome model as an optimization later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, i just took this function from the other tests where it was
we can use that model if we merge it first