Nudge PRs to have linked issues, visual demos #836
Conversation
bharatkashyap
commented
Aug 22, 2022
bharatkashyap
commented
- I have followed (at least) the PR section of the contributing guide.
|
Your Render PR Server URL is https://toolpad-pr-836.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cc1l0k1gp3jk4km8iqb0. |
oliviertassinari
requested a deployment
to
update-pr-template - toolpad-db PR #836
Render
Abandoned
.github/PULL_REQUEST_TEMPLATE.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| <!-- Thanks so much for your PR, your contribution is appreciated! ❤️ --> | |||
|
|
|||
| - [ ] I have followed (at least) the [PR section of the contributing guide](https://github.com/mui/material-ui/blob/HEAD/CONTRIBUTING.md#sending-a-pull-request). | |||
| - Fixes <!-- Issue hyperlink --> | |||
There was a problem hiding this comment.
Should we add checkboxes? We could later introduce a PR check which validates that all boxes are checked.
There were concerns about increased friction, but IMO adding a x between [ ] should not be such a huge friction
There was a problem hiding this comment.
I feel like adding the checkbox adds very little value, since I would rather just add the image instead of checking a box
There was a problem hiding this comment.
I brought it up only because it allows us to use PR checks to validate if action was done, however it's fine if we skip that for now since we don't have checks anyways 👍
bharatkashyap
changed the title
|
Your Render PR Server URL is https://toolpad-pr-836.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cc714ct3t399edq1on60. |
oliviertassinari
requested a deployment
to
update-pr-template - toolpad-db PR #836
Render
Abandoned
bharatkashyap
requested review from
bytasv and
oliviertassinari
and removed request for
bytasv and
oliviertassinari
