Improve QueryEditor flow #844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://toolpad-pr-844.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-cc2gqfqrrk0fs3nnf0mg. |
oliviertassinari
requested a deployment
to
query-editor-flow - toolpad-db PR #844
Render
Abandoned
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
apedroferreira
approved these changes
Aug 25, 2022
| export default function useBoolean(initialValue: boolean) { | ||
| const [value, setValue] = React.useState(initialValue); | ||
| const toggle = React.useCallback(() => setValue((existing) => !!existing), []); | ||
| const set = React.useCallback(() => setValue(true), []); |
There was a problem hiding this comment.
if we plan to reuse this hook a lot maybe the names of the props could be a bit more intuitive?
maybe even something like setTrue or setFalse?
There was a problem hiding this comment.
set/reset is quite common nomenclature in boolean logic, but I have no strong feelings about it, I renamed it to setTrue/setFalse
There was a problem hiding this comment.
ok i hadn't heard about it, not a big deal. thanks for the change though!
There was a problem hiding this comment.
Maybe it's more common in electronic circuits 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #798