Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Props panel sections #855

Merged
merged 4 commits into from
Aug 30, 2022
Merged

Props panel sections #855

merged 4 commits into from
Aug 30, 2022

Conversation

apedroferreira
Copy link
Member

@apedroferreira apedroferreira commented Aug 25, 2022 •
edited
Loading

Closes #819

  • Separate component name/id section from layout properties section and component properties section - by using dividers, spacing and trying to improve the typography hierarchy a bit
  • Reordered properties of each component to try to make them a bit more logical - if we want to split them more and categorize them in groups we can probably do it separately as I mentioned in the issue (In the right pane, props and component name should be visually separated #819)

Component with layout props:

Screen Shot 2022-08-26 at 16 13 05

Component without layout props:

Screen Shot 2022-08-26 at 16 13 12

@oliviertassinari oliviertassinari requested a deployment to props-panel-sections - toolpad-db PR #855 August 25, 2022 18:33 — with Render Abandoned
@oliviertassinari oliviertassinari temporarily deployed to props-panel-sections - toolpad PR #855 August 26, 2022 15:12 — with Render Destroyed
@oliviertassinari oliviertassinari temporarily deployed to props-panel-sections - toolpad PR #855 August 26, 2022 15:12 — with Render Destroyed
@apedroferreira apedroferreira marked this pull request as ready for review August 26, 2022 15:16
@apedroferreira
Copy link
Member Author

@prakhargupta1 does this work for now?

@apedroferreira apedroferreira self-assigned this Aug 29, 2022
@apedroferreira apedroferreira merged commit ac128f4 into master Aug 30, 2022
@apedroferreira apedroferreira deleted the props-panel-sections branch August 30, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@apedroferreira apedroferreira

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In the right pane, props and component name should be visually separated
2 participants
@apedroferreira @oliviertassinari