[website] Improve video poster #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
force-pushed
the
fix-video-poster
branch
2 times, most recently
from
3a567fa to
5a702ad
Compare
oliviertassinari
force-pushed
the
fix-video-poster
branch
from
5a702ad to
b62e00c
Compare
Janpot
approved these changes
Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The poster we were using was, IMHO, a bit strange:
The new poster I'm proposing is the first frame of the video
ffmpeg -i hero-video.mp4 -vf "scale=iw*sar:ih,setsar=1" -vframes 1 filename.jpg.The new poster I'm proposing is x10 smaller
https://deploy-preview-892--mui-toolpad-docs.netlify.app/toolpad/