Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put Toolpad user in charge of response parsing #987

Merged
merged 3 commits into from
Sep 13, 2022
Merged

Put Toolpad user in charge of response parsing #987

merged 3 commits into from
Sep 13, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Sep 12, 2022 •
edited
Loading

  • Put user in charge of how responses are parsed.
  • We default to json, but user can choose to use the raw response.
  • later on we could add csv and xml parsers as well.
  • later on we could add a message when the content-type header doesn't match and direct users to the "response" tab.
  • if for some reason users want to put the server in charge, we can always add a "detect" mode
Screen.Recording.2022-09-13.at.11.19.49.mov

@render
Copy link

render bot commented Sep 12, 2022

Your Render PR Server URL is https://toolpad-pr-987.onrender.com.

Follow its progress at https://dashboard.render.com/web/srv-ccfmam6n6mps829rnnrg.

@oliviertassinari oliviertassinari requested a deployment to response-parse - toolpad-db PR #987 September 12, 2022 16:59 — with Render Abandoned
@Janpot Janpot changed the title automatically parse all fetch responses based on content sniffing automatically parse all fetch responses by content sniffing Sep 13, 2022
@Janpot Janpot changed the title automatically parse all fetch responses by content sniffing Automatically parse all fetch responses by content sniffing Sep 13, 2022
@Janpot Janpot changed the title Automatically parse all fetch responses by content sniffing Toolpad user should be in charge of response handling Sep 13, 2022
@Janpot Janpot changed the title Toolpad user should be in charge of response handling Put Toolpad user in charge of response parsing Sep 13, 2022
@Janpot Janpot merged commit f089846 into master Sep 13, 2022
@Janpot Janpot deleted the response-parse branch September 13, 2022 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharatkashyap bharatkashyap bharatkashyap approved these changes

Assignees
No one assigned
Labels
Toolpad
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Janpot @bharatkashyap @oliviertassinari @zannager