Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Self-document integration test mode #995

Merged
merged 4 commits into from
Sep 14, 2022
Merged

Self-document integration test mode #995

merged 4 commits into from
Sep 14, 2022

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Sep 14, 2022

  • Rename TOOLPAD_INTEGRATION_TEST to TOOLPAD_ENABLE_CREATE_BY_DOM: This signals the exact purpose to maintainers, to prevent abusing it for other purposes. e.g. to make a test pass.
  • This also allows us to configure our PR previews with this variable to make it easier to test production setups on PR previews.
  • Throw a meaningful error when integration tests are run when this variable is not set. (Allow duplicating apps #658 (comment))
  • Make sure all integration tests use the same code path to create their applications, so they perform the check of this PR.

@render
Copy link

render bot commented Sep 14, 2022

@Janpot Janpot mentioned this pull request Sep 14, 2022
1 task
@Janpot Janpot marked this pull request as ready for review September 14, 2022 12:38
Copy link
Member

@bharatkashyap bharatkashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it!

@Janpot Janpot merged commit 039c40b into master Sep 14, 2022
@Janpot Janpot deleted the integration-test-var branch September 14, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants