feat: Add ReplaceNamed(), InsertBeforeNamed(), and InsertAfterNamed() #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #63 +/- ##
==========================================
+ Coverage 83.89% 84.40% +0.50%
==========================================
Files 21 22 +1
Lines 3024 3186 +162
==========================================
+ Hits 2537 2689 +152
- Misses 317 323 +6
- Partials 170 174 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
muir
commented
Apr 1, 2023
|
|
||
| // This demonstrates how it to have a default that gets overridden by | ||
| // by later inputs using Reorder | ||
| func ExampleReorder() { |
muir
changed the title
sharnoff
approved these changes
Apr 1, 2023
replace.go
Outdated
| // be tagging a colleciton, not an individual. | ||
| func (c *Collection) handleReplaceByName() (err error) { | ||
| defer func() { | ||
| // if err != nil { |
There was a problem hiding this comment.
is this meant to be commented out?
replace.go
Outdated
| if err != nil { | ||
| return err | ||
| } | ||
| firstMove, lastMove := snip(n, func(n *node) bool { return n.fm.insertBeforeName == name }) |
There was a problem hiding this comment.
Suggested change
| firstMove, lastMove := snip(n, func(n *node) bool { return n.fm.insertBeforeName == name }) | |
| firstMove, lastMove := snip(n, func(n *node) bool { return n.fm.insertAfterName == name }) |
replace.go
Outdated
| // step 4, convert back to list | ||
| contents := make([]*provider, 0, len(c.contents)) | ||
| for n := head.next; n != tail; n = n.next { | ||
| if n.fm != nil && n.fm.fn != nil { |
There was a problem hiding this comment.
can this condition be false?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New functions that allow manipulating the injection chain using the names assigned with
Provide()