Create-only appliance local region ID

mukeshmv · Oct 28, 2024 · cd6303b · cd6303b
1 parent 891f406
commit cd6303b
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/dash-pipeline/Makefile b/dash-pipeline/Makefile
@@ -183,14 +183,14 @@ DOCKER_RUN_SAITHRIFT_BLDR =\
 
 # TODO - create separate rules for headers, libsai.so
 .PHONY:sai
-sai: sai-headers sai-meta libsai
+sai: sai-headers
 
-sai-headers: p4 docker-saithrift-bldr-image-exists | SAI/SAI
+sai-headers: p4 docker-saithrift-bldr-image-exists
 	@echo "Generate SAI library headers and implementation..."
 
 	# Revert any local changes before generating the new specs.
-	git clean -xf SAI/specs
-	git checkout SAI/specs/*
+	#git clean -xf SAI/specs
+	#git checkout SAI/specs/*
 
 	mkdir -p SAI/lib
 

diff --git a/dash-pipeline/SAI/SAI b/dash-pipeline/SAI/SAI
diff --git a/dash-pipeline/SAI/specs/dash_appliance.yaml b/dash-pipeline/SAI/specs/dash_appliance.yaml
@@ -17,7 +17,7 @@ sai_apis:
     attr_value_field: u8
     default: '0'
     isresourcetype: false
-    flags: CREATE_AND_SET
+    flags: CREATE_ONLY
     object_name: null
     allow_null: false
     valid_only: null

diff --git a/dash-pipeline/SAI/utils/sai_spec/sai_attribute.py b/dash-pipeline/SAI/utils/sai_spec/sai_attribute.py
@@ -27,6 +27,7 @@ def __init__(
         self.attr_value_field = attr_value_field
         self.default = default
         self.isresourcetype = isresourcetype
+        print(f"attr {name} flag {flags}")
         self.flags = flags
         self.object_name = object_name
         self.allow_null = allow_null
@@ -40,4 +41,4 @@ def merge(self, other: "SaiCommon"):
 
     def deprecate(self) -> bool:
         self.deprecated = True
-        return False
+        return False