Skip to content

Commit

Permalink
fix(encoder): missing error details on calculateDataSize, add more de…
Browse files Browse the repository at this point in the history
…tails for verbosity (#22)
  • Loading branch information
muktihari committed Nov 30, 2023
1 parent 952c9f8 commit 63857e9
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions encoder/encoder.go
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,10 @@ func (e *Encoder) updateHeader(header *proto.FileHeader) error {
func (e *Encoder) calculateDataSize(fit *proto.Fit) error {
n := e.n
for i := range fit.Messages { // calculating messages actual size
if err := e.encodeMessage(io.Discard, &fit.Messages[i]); err != nil {
return err
mesg := &fit.Messages[i]
if err := e.encodeMessage(io.Discard, mesg); err != nil {
return fmt.Errorf("encode failed: at byte pos: %d, message index: %d, num: %d (%s): %w",
e.n, i, mesg.Num, mesg.Num.String(), err)
}
}

Expand Down Expand Up @@ -376,9 +378,10 @@ func (e *Encoder) encodeMessages(messages []proto.Message) error {
}

for i := range messages {
if err := e.encodeMessage(e.w, &messages[i]); err != nil {
return fmt.Errorf("encode failed: at byte pos: %d, message index: %d, num: %d: %w",
e.n, i, messages[i].Num, err)
mesg := &messages[i]
if err := e.encodeMessage(e.w, mesg); err != nil {
return fmt.Errorf("encode failed: at byte pos: %d, message index: %d, num: %d (%s): %w",
e.n, i, mesg.Num, mesg.Num.String(), err)
}
}

Expand Down

0 comments on commit 63857e9

Please sign in to comment.