fix(decoder): Next() returned false where it should be true (#9)

muktihari · Oct 13, 2023 · 6f85954 · 6f85954
1 parent 76b86da
commit 6f85954
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/decoder/decoder.go b/decoder/decoder.go
@@ -243,7 +243,7 @@ func (d *Decoder) Next() bool {
 	d.initDecodeHeaderOnce() // reset to enable invocation.
 
 	// err is saved in the func, any exported will call this func anyway.
-	return d.decodeHeaderOnce() != nil
+	return d.decodeHeaderOnce() == nil
 }
 
 // DecodeWithContext wraps Decode to respect context propagation.

diff --git a/decoder/decoder_test.go b/decoder/decoder_test.go
@@ -423,7 +423,10 @@ func TestNext(t *testing.T) {
 	}
 
 	// Check whether after decode, fields are reset and next sequence is retrieved.
-	dec.Next()
+
+	if !dec.Next() {
+		t.Fatalf("should have next, return false")
+	}
 
 	if prevAccumulator == dec.accumulator {
 		t.Fatalf("expected new accumulator got same")