perf: clean up proto and improve mesgdef (#64)

muktihari · Dec 23, 2023 · ec124c4 · ec124c4
1 parent fda586c
commit ec124c4
Show file tree

Hide file tree

Showing 106 changed files with 2,046 additions and 5,964 deletions.
diff --git a/internal/cmd/fitgen/profile/mesgdef/mesgdef.tmpl b/internal/cmd/fitgen/profile/mesgdef/mesgdef.tmpl
@@ -66,35 +66,30 @@ func New{{ .Name }}(mesg *proto.Message) *{{ .Name }} {
 
 // ToMesg converts {{ .Name }} into proto.Message.
 func (m *{{ .Name }}) ToMesg(fac Factory) proto.Message {
+    fieldsPtr := fieldsPool.Get().(*[256]proto.Field)
+    defer fieldsPool.Put(fieldsPtr)
+
+    fields := (*fieldsPtr)[:0] // Create slice from array with zero len.
     mesg := fac.CreateMesgOnly(typedef.MesgNum{{ .Name }})
-	mesg.Fields = make([]proto.Field, 0, m.size())
-
+
     {{ range .Fields -}}
         if {{ .ComparableValue }} != {{ .InvalidValue }} {
             field := fac.CreateField(mesg.Num, {{ .Num }})
             field.Value = {{ .PrimitiveValue }}
-            mesg.Fields = append(mesg.Fields, field)
+            fields = append(fields, field)
         }
 	{{ end }}
 
+    mesg.Fields = make([]proto.Field, len(fields))
+    copy(mesg.Fields, fields)
+
 	{{ if and (not (eq .Name "FileId")) (not (eq .Name "DeveloperDataId")) (not (eq .Name "FieldDescription"))  }}
 	mesg.DeveloperFields = m.DeveloperFields
 	{{ end }}
 
 	return mesg
 }
 
-// size returns size of {{ .Name }}'s valid fields.
-func (m *{{ .Name }}) size() byte {
-    var size byte
-    {{ range .Fields -}}
-        if {{ .ComparableValue }} != {{ .InvalidValue }} {
-            size++
-        }
-	{{ end -}}
-    return size
-}
-
 {{ range .Fields -}}
 // Set{{ .Name }} sets {{ $.Name }} value.
 //

diff --git a/profile/mesgdef/accelerometer_data_gen.go b/profile/mesgdef/accelerometer_data_gen.go
diff --git a/profile/mesgdef/activity_gen.go b/profile/mesgdef/activity_gen.go
diff --git a/profile/mesgdef/ant_channel_id_gen.go b/profile/mesgdef/ant_channel_id_gen.go