Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: mesgdef clean up code #389

Merged
merged 3 commits into from
Aug 31, 2024
Merged

chore: mesgdef clean up code #389

merged 3 commits into from
Aug 31, 2024

Conversation

muktihari
Copy link
Owner

  • Remove invalid value check on degrees method as kit/semicircles already handle it.
  • Clean up mesgdef.tmpl replace four space with one tab (\t)

@muktihari muktihari added the chore update not related to the functionality of the sdk, e.g. update workflow label Aug 31, 2024
@muktihari muktihari self-assigned this Aug 31, 2024
@muktihari muktihari added this to the v0.21.3 milestone Aug 31, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (be543d0) to head (fb99c84).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #389   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        41           
  Lines         3689      3689           
=========================================
  Hits          3689      3689           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit 7bdf0df into master Aug 31, 2024
4 checks passed
@muktihari muktihari deleted the chore/mesgdef-clean-up-code branch August 31, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore update not related to the functionality of the sdk, e.g. update workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants