Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: refactor fitactivity #398

Merged
merged 3 commits into from
Sep 7, 2024
Merged

cli: refactor fitactivity #398

merged 3 commits into from
Sep 7, 2024

Conversation

muktihari
Copy link
Owner

New Feature

This PR adds new feature "reduce" to reduce record messages in a FIT file to answer this issue #394 .

This has 3 method to choose:

  1. Based on GPS points using RDP Ramer-Douglas-Peucker.
  2. Based on distance interval in meters
  3. Based on time interval in seconds`

Refactor

How we can interact with fitactivity CLI is also refactored for more structured commands (arguably easier to access and maintain). Some commands may differ, but they should be simple to follow. cmd/fitactivity/README.md file has been updated accordingly regarding the changes.

@muktihari muktihari added the enhancement New feature or request label Sep 7, 2024
@muktihari muktihari self-assigned this Sep 7, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (2979f67) to head (52cf188).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #398   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        41           
  Lines         3691      3691           
=========================================
  Hits          3691      3691           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit 90ee441 into master Sep 7, 2024
4 checks passed
@muktihari muktihari deleted the cli/refactor-fitactivity branch September 7, 2024 17:15
@muktihari muktihari modified the milestone: v0.21.3 Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants