Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: remove not particularly useful features #418

Merged
merged 22 commits into from
Sep 12, 2024
Merged

refactor!: remove not particularly useful features #418

merged 22 commits into from
Sep 12, 2024

Commits on Sep 11, 2024

  1. proto: remove CreateMessageDefinition, CreateMessageDefinitionTo and … 

    …WithMessages
    @muktihari
    muktihari committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    8ad4e1f View commit details
    Browse the repository at this point in the history

  2. proto: remove Message's WithFields and WithDeveloperFields method

    @muktihari
    muktihari committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    d727a77 View commit details
    Browse the repository at this point in the history

  3. remove internal/kit

    @muktihari
    muktihari committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    e1c5036 View commit details
    Browse the repository at this point in the history

  4. remove (Message) WithFieldValues

    @muktihari
    muktihari committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    439812a View commit details
    Browse the repository at this point in the history

  5. remove all Clone() method

    @muktihari
    muktihari committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    51e3b70 View commit details
    Browse the repository at this point in the history

  6. encoder: add unit test for newMessageDefinition

    @muktihari
    muktihari committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    fc93dee View commit details
    Browse the repository at this point in the history

  7. remove factory CreateMesgOnly

    @muktihari
    muktihari committed Sep 11, 2024
    Configuration menu
    Copy the full SHA
    328efc4 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2024

  1. decoder: make Accumulator values private and update docs

    @muktihari
    muktihari committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    a76a593 View commit details
    Browse the repository at this point in the history

  2. encoder: allocate mesgDef fields and developerFields upfront size 255

    @muktihari
    muktihari committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b6becfc View commit details
    Browse the repository at this point in the history

  3. proto: remove constant MaxBytesPerMessage and MaxBytesPerMessageDefin… 

    …ition
    @muktihari
    muktihari committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f39e616 View commit details
    Browse the repository at this point in the history

  4. proto: change FileHeader.ProtocolVersion type to proto.Version instea… 

    …d of byte
    @muktihari
    muktihari committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    89cdb27 View commit details
    Browse the repository at this point in the history

  5. chore: update Factory interface code docs

    @muktihari
    muktihari committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    8ac7805 View commit details
    Browse the repository at this point in the history

  6. decoder: rename ErrNotAFitFile to ErrNotFITFile

    @muktihari
    muktihari committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    c787d2d View commit details
    Browse the repository at this point in the history

  7. decoder: remove idempotent guarantee for PeekFileHeader and PeekFileI… 

    …d as we might change the behavior later
    @muktihari
    muktihari committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    f053e10 View commit details
    Browse the repository at this point in the history

  8. docs: update documentation

    @muktihari
    muktihari committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    fdce53a View commit details
    Browse the repository at this point in the history

  9. fuzz: ignore mesgDef reserved

    @muktihari
    muktihari committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    d919b60 View commit details
    Browse the repository at this point in the history

  10. basetype: remove IsInteger() EndianAbility() method, add EndianAbilit… 

    …yMask
    @muktihari
    muktihari committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    9990347 View commit details
    Browse the repository at this point in the history

  11. remove: Reserved and Architecture fields from Message

    @muktihari
    muktihari committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    097b558 View commit details
    Browse the repository at this point in the history

  12. proto: move LocalMesgNum and NewMessageDefinition functions to bottom

    @muktihari
    muktihari committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    5a65535 View commit details
    Browse the repository at this point in the history

  13. chore: clean up proto_marshal_test.go code

    @muktihari
    muktihari committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b796c2d View commit details
    Browse the repository at this point in the history

  14. encoder: simplify encodeCRC

    @muktihari
    muktihari committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    b75f50d View commit details
    Browse the repository at this point in the history

  15. decoder: reset on Decode, make Next as optional

    @muktihari
    muktihari committed Sep 12, 2024
    Configuration menu
    Copy the full SHA
    1961084 View commit details
    Browse the repository at this point in the history