refactor!: decoder sentinel errors #428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we only keep value when fieldNum is 253 and the value type is uint32. We no longer return ErrFieldValueTypeMismatch error when the fieldNum 253 is not an uint32, as there is no documentation that say 253 must be for timestamp and we found some old message may have timestamp for other fieldNum such as CoursePoint and Set messages, although these messages may be created before the rule was put in place. We think that maybe some manufacturers use this fieldNum for something else as well. We don't think returning error will add any value.
Some errors are deleted or make private; ErrDataSizeZero is deleted and an ErrNotFITFile will be returned instead when FileHeader's DataSize is zero.