Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: decoder sentinel errors #428

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

muktihari
Copy link
Owner

  • Now we only keep value when fieldNum is 253 and the value type is uint32. We no longer return ErrFieldValueTypeMismatch error when the fieldNum 253 is not an uint32, as there is no documentation that say 253 must be for timestamp and we found some old message may have timestamp for other fieldNum such as CoursePoint and Set messages, although these messages may be created before the rule was put in place. We think that maybe some manufacturers use this fieldNum for something else as well. We don't think returning error will add any value.

  • Some errors are deleted or make private; ErrDataSizeZero is deleted and an ErrNotFITFile will be returned instead when FileHeader's DataSize is zero.

@muktihari muktihari added the enhancement New feature or request label Sep 13, 2024
@muktihari muktihari added this to the v0.23.0 milestone Sep 13, 2024
@muktihari muktihari self-assigned this Sep 13, 2024
@muktihari muktihari changed the title refactor!: decoder errors refactor!: decoder sentinel errors Sep 13, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (fca545d) to head (90fce47).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #428   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         3674      3672    -2     
=========================================
- Hits          3674      3672    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit 68a45e7 into master Sep 13, 2024
5 checks passed
@muktihari muktihari deleted the refactor/decoder-errors branch September 13, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants