Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up proto Value code #435

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Conversation

muktihari
Copy link
Owner

  • Update (Value) SliceBool code documentation: []bool into []typedef.Bool
  • Simplify string len counting in proto.Sizeof
  • Update switch's cases ordering to match proto Type's constants order for consistency.

@muktihari muktihari added the chore update not related to the functionality of the sdk, e.g. update workflow label Sep 15, 2024
@muktihari muktihari self-assigned this Sep 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (72de0f3) to head (bdc9293).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #435   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         3669      3658   -11     
=========================================
- Hits          3669      3658   -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

proto/value_marshal.go Dismissed Show dismissed Hide dismissed
proto/value_marshal.go Dismissed Show dismissed Hide dismissed
proto/value_marshal.go Dismissed Show dismissed Hide dismissed
proto/value_marshal.go Dismissed Show dismissed Hide dismissed
proto/value_marshal.go Dismissed Show dismissed Hide dismissed
proto/value_marshal.go Dismissed Show dismissed Hide dismissed
proto/value_marshal.go Dismissed Show dismissed Hide dismissed
@muktihari muktihari merged commit e2c16ec into master Sep 15, 2024
5 checks passed
@muktihari muktihari deleted the chore/clean-up-proto-value branch September 15, 2024 15:26
@muktihari muktihari added this to the v0.23.0 milestone Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore update not related to the functionality of the sdk, e.g. update workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants