Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle compressed timestamp #438

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Conversation

muktihari
Copy link
Owner

  • decoder: Compressed timestamp header message has local message type 0-3 positioned at bit 5-6 (note: normal message has local message type 0-15 positioned at bit 0-4). Bit 6 overlap with proto.MesgDefinitionMask, the only thing that differentiate them is the bit 7. So we must take bit 7 into consideration when checking the header type, is it message definition or is it message data. Since only message has value at header bit 7, we we must include proto.MesgCompressedHeaderMask to do mask, only then we can get the correct header type.
  • encoder: Previous implementation of timestamp compression has a bug, where we always has timestampReference 1. It should have only been updated when Rollover Event occurs.

@muktihari muktihari added the bug Something isn't working label Sep 16, 2024
@muktihari muktihari added this to the v0.23.0 milestone Sep 16, 2024
@muktihari muktihari self-assigned this Sep 16, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (1c69559) to head (90dc307).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #438   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         3659      3661    +2     
=========================================
+ Hits          3659      3661    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit c5bf0c3 into master Sep 16, 2024
5 checks passed
@muktihari muktihari deleted the fix/handle-compressed-timestamp branch September 16, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants