Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: encoder compress timestamp with multiple local message type #439

Merged

Conversation

muktihari
Copy link
Owner

At the beginning, I thought that when using compressed timestamp, we can only use local message type zero, but after a year, I re-read the documentation again, it turns out that we can use 0-3 local message type.

Message (Data) 's Header bit layout:

Bit Value Desc
7 1 Compressed Timestamp Header
5 – 6 0 - 3 Local Message Type
0 - 4 0 - 31 Time Offset (seconds)

With this being implemented, I think how FIT SDK handle compressed timestamp is finally completed. This change comes with breaking changes, dropping WithNormalHeader and WithCompressedTimestampHeader encoder options, replaced with WithHeaderOption

@muktihari muktihari added the enhancement New feature or request label Sep 16, 2024
@muktihari muktihari added this to the v0.23.0 milestone Sep 16, 2024
@muktihari muktihari self-assigned this Sep 16, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c5bf0c3) to head (05e4d16).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #439   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         3661      3664    +3     
=========================================
+ Hits          3661      3664    +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit 1426653 into master Sep 16, 2024
5 checks passed
@muktihari muktihari deleted the feat/encoder-implement-compress-timestamp-interleave branch September 16, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants