Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: protocol validator export protocol version field #449

Merged

Conversation

muktihari
Copy link
Owner

We don't need getter and setter for field that can be changed directly.

@muktihari muktihari added the enhancement New feature or request label Sep 17, 2024
@muktihari muktihari added this to the v0.23.0 milestone Sep 17, 2024
@muktihari muktihari self-assigned this Sep 17, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (0816fc0) to head (8f87940).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #449   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         3661      3659    -2     
=========================================
- Hits          3661      3659    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit 6d72369 into master Sep 17, 2024
5 checks passed
@muktihari muktihari deleted the fix/protocol-validator-export-protocol-version-field branch September 17, 2024 03:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants