Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation of component expansion does not accommodate containing field's value more than 32 bits. This results in expanding incorrect components for messages that has more than 32 bits such as "Hr"
event_timestamp_12
(up to 120 bits) and "RawBbi"data
(up to 240 bits).By design, field's value requiring expansion can hold up to 255 bytes (2040 bits) data, this is obviously way more bits than Go's primitive single value can hold. To handle this, I implement new type "bits" struct that can store up to 2048 bits data, enable us to do bitwise operation over it for component expansion.
To test the correctness, I use sample data from "testdata/from_official_sdk/activity_poolswim_with_hr.csv", as it contains 96 bits data to be expanded and the new implementation produces the correct values as in the CSV file.