refactor!: perf and memory optimization #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
muktihari
commented
Dec 18, 2023
•
muktihari
commented
- perf: all constants stringer no longer use map and do not allocate any variables, it use switch-case just like golang stringer.
- feat: update on decode and encode array value and other improvements
- add new field "Array" in proto.Field, factory updated.
- decoder and unmarshal now decide when to unmarshal array value based on field.Array not based on the size of data.
- enable []string, implemented in:
- typedef/marshal.go
- typtedf/unmarshal.go
- typedef/typedef.go
- decoder/decoder.go
- encoder/encoder.go
- encoder/validator.go
- kit/typeconv/basetypeconv.go
- factory CreateMesg no longer deep clone, only shallow clone the fields to improve performance.
- factory predefined messages now use array instead of slice, and it's separated from registered messages.
- perf: optimize mesgdef on convert back to proto.Message
- fix: code affected by mesgdef changes
- feat: update on filedef implementation
- course and workout now can convert back to fit, enabling it for encoding.
- docs: update on common files documentation
- chore: encoder's encodeMessages method now receive writer
- add new field "Array" in proto.Field, factory updated. - decoder and unmarshal now decide when to unmarshal array value based on field.Array not based on the size of data. - enable []string, implemented in: - typedef/marshal.go - typtedf/unmarshal.go - typedef/typedef.go - decoder/decoder.go - encoder/encoder.go - encoder/validator.go - kit/typeconv/basetypeconv.go - factory CreateMesg no longer deep clone, only shallow clone the fields to improve performance. - factory predefined messages now use array instead of slice, and it's separated from registered messages.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 19 24 +5
Lines 2542 2935 +393
==========================================
+ Hits 2542 2935 +393 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.