Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: decoder component expansion on handling edge case #484

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

muktihari
Copy link
Owner

@muktihari muktihari commented Oct 7, 2024

This PR update component expansion logic on handling edge case such as when a message already has field with the same field number as the expanded field candidate (component field). For such cases, the value of the field will be updated, including the component expansion that is propagated.

For a case like this, typically, the value of the field is the same with the value of the expanded field. For example a record message has speed and enhanced_speed with the same value before the expansion, after the expansion the value will be the same.

@muktihari muktihari added the bug Something isn't working label Oct 7, 2024
@muktihari muktihari added this to the Unreleased milestone Oct 7, 2024
@muktihari muktihari self-assigned this Oct 7, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (190e0e4) to head (e85a983).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #484   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           42        42           
  Lines         3848      3853    +5     
=========================================
+ Hits          3848      3853    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@muktihari muktihari merged commit fa631b9 into master Oct 7, 2024
5 checks passed
@muktihari muktihari deleted the fix/decoder-component-expansion-on-edge-case branch October 7, 2024 04:27
@muktihari muktihari added this to the v0.24.4 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants